Add FSTAR_USE_KRML_EXE; migrate from KRML_HOME to KRML_EXE#4349
Merged
mtzguido merged 2 commits intoJul 16, 2026
Conversation
tahina-pro
added a commit
to tahina-pro/quackyducky
that referenced
this pull request
Jul 14, 2026
mtzguido
force-pushed
the
_taramana_krml_home_to_exe
branch
from
July 16, 2026 00:37
87f9319 to
88204f9
Compare
Member
|
Tweaked it a bit, LGTM. |
Add support for FSTAR_USE_KRML_EXE=1, which skips building the karamel/ submodule and instead uses an existing Karamel executable given by the KRML_EXE environment variable. The default behavior (building the submodule) is unchanged. Migrate the Pulse test Makefiles and the rest of the tree from KRML_HOME to KRML_EXE: - Makefile: guard the karamel build with FSTAR_USE_KRML_EXE; skip the per-stage karamel install in that mode; pass KRML_EXE (not KRML_HOME) to the Pulse test/accept targets. The in-tree default points at the installed executable, karamel/out/bin/krml. - Pulse dice/cbor examples: use KRML_EXE, and `krml -locate-include` / `-locate-krmllib` for C include paths. These paths (and KRML_EXE itself) are quoted at every use site so they tolerate whitespace in the location (e.g. C:\Program Files on Windows). - pulse/mk/locate.mk: drop the KRML_HOME fallback (default to `krml`). - examples/tactics(+bench), pulse2rust/dpe, pulse CI workflow, devcontainer Dockerfile, docker/advance build scripts, and docs. Inspired by project-everest/everparse#298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mtzguido
force-pushed
the
_taramana_krml_home_to_exe
branch
from
July 16, 2026 00:37
88204f9 to
dd60dc9
Compare
mtzguido
enabled auto-merge
July 16, 2026 00:37
Member
Author
|
Thanks a lot Guido! |
tahina-pro
added a commit
to tahina-pro/quackyducky
that referenced
this pull request
Jul 20, 2026
tahina-pro
added a commit
to FStarLang/karamel
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
FSTAR_USE_KRML_EXE=1, which skips building thekaramel/submodule and instead uses an existing Karamel executable given by theKRML_EXEenvironment variable. The default behavior (building the submodule) is unchanged.This PR also migrates the Pulse test Makefiles and the rest of the tree from
KRML_HOMEtoKRML_EXE:Makefile: guard the Karamel build withFSTAR_USE_KRML_EXE; skip the per-stage Karamel install in that mode; passKRML_EXE(notKRML_HOME) to the Pulse test/accept targets. The in-tree default points at the installed executable,karamel/out/bin/krml.dice/cborexamples: useKRML_EXE, andkrml -locate-include/-locate-krmllibfor C include paths. These paths (andKRML_EXEitself) are quoted at every use site so they tolerate whitespace in the location (e.g. Windows).pulse/mk/locate.mk: drop theKRML_HOMEfallback (default tokrml).Inspired by project-everest/everparse#298.